[#1350] Escape chars in DotFileFormatSimple #1360
Conversation
- introduce test which checks escaping for DotFileFormatSimple - reformat string declarations - remove DotFormat param from checkWriteOutput(). We dont need that since we escape chars for both formats fixes dbs-leipzig#1350
- remove spurious semicolon
There was a problem hiding this comment.
HTML encoding fits not here. Try to open a dot file with gephi and you will see that it can not interpret it as a quote. The right way is to encode each " with a " ... having this, gephi successfully imports the data and parses the escaped quote to a quote in the data explorer.
But then the question arises whether we should cater for a gephi specific problem. If i create a png using graphviz, the html escaped characters are properly rendered. Its just gephi who does not understand these sequences and takes all of the chars "as is" (at least thats what i'm seeing in the data view). I think we need to decide whether the simple format will primarily be used to render graphs in gephi or to render simpler graphics with graphviz. |
And the same for escaping a quote with a backslash (See image) Because this ecaping works with gephi and graphviz (please chack again with your examples), we should use this. |
ChrizZz110
added
READY FOR MERGE
we escape chars for both formats
fixes #1350